Hi,

I was testing the Episerver prerelease 11.1.0 with Alloy demo site and noticed that sometimes the container pages were displayed in the top navigation (they shouldn't be).

Steps:

• install new site with VS extension, target framework 4.7
• update Episerver NuGet packages to the prerelease version 11.1.0 (Episerver update 186)
• see my exact steps in this blog post: https://swapcode.wordpress.com/2017/11/05/testing-episerver-prerelease-11-1-0-with-alloy/
• clean & rebuild => F5 run the site
• depending on the position of moon and sun the container pages might be visible the top menu or not
  • just keep trying ;P

I debugged the code and believe I found the reason why this might happen. To me it looks like the injected property template resolver in FilterTemplate class can get the wrong implementation (not the same that the Alloy CustomizedRenderingInitialization has hooked event handler to). So in short I think the EPiServer.Web.Internal.TemplateResolverImplementation and EPiServer.Web.Internal.DefaultTemplateResolver registration are competing in the registration order randomly and that is why the FilterTemplate might get the "wrong" implementation.

Debug logging when working incorrectly:

CustomizedRenderingInitialization, registering for templateresolver (type: EPiServer.Web.Internal.TemplateResolverImplementation, hashcode: 40517777).

FilterForDisplay, templateFilter templateresolver type: EPiServer.Web.Internal.DefaultTemplateResolver, hashcode: 23615301

// eventhandler in [Alloy].Business.Rendering.TemplateCoordinator.OnTemplateResolved
Set SelectedTemplate = null, templateresolver hashcode: 40517777, type: EPiServer.Web.Internal.TemplateResolverImplementation

So as you can see from above log entries the menu creation used FilterForDisplay method used TemplateFilter is using another implementation for the templateresolver => no events for the registered handler that would set the template to null for container pages.

Debug logging when working correctly (the container pages are not shown in the menu):

CustomizedRenderingInitialization, registering for templateresolver (type: EPiServer.Web.Internal.TemplateResolverImplementation, hashcode: 62773796).

FilterForDisplay, templateFilter templateresolver type: EPiServer.Web.Internal.TemplateResolverImplementation, hashcode: 62773796

// event handler in [Alloy].Business.Rendering.TemplateCoordinator.OnTemplateResolved
Set SelectedTemplate = null, templateresolver hashcode: 62773796, type: EPiServer.Web.Internal.TemplateResolverImplementation

Here you can see that the TemplateFilter is using the same implementation and instance as the registered handler and the pagecontainer templates are correctly set to null and not visible in the menu.

Looking at the code I can see that the DefaultTemplateResolver has no module dependency when it is registered just with the ServiceConfiguration-attribute and the TemplateResolverImplemenation is registered using dependency to CmsCoreInitialization (EPiServer.Initialization.Internal.TemplateInitialization).

Might be that this is already fixed in mondays bits :)