Hi

Episerver Find extension method ContentSearchExtensions.FilterOnReadAccess is broken. It no longer returns any results for anonymous users.

The issue happens with the latest nugets:
EPiServer.CMS.Core 9.8.1
EPiServer.Find 11.1.4.4296
EPiServer.Find.Cms 11.1.4.4296
EPiServer.Find.Framework 11.1.4.4296

It seems that the issue is caused by changes in EPiServer.Security.VirtualRoleRepository, which has method VirtualRoleRepository.GetDefault() for obtaining an instance. The method is now deprecated and no longer works as it should, but the latest Find nuget uses it. The fix is to use IoC to obtain the instance.

    // Class: EPiServer.Find.Cms.ContentSearchExtensions
    private static IEnumerable GetCurrentUsersRoles()
    {
      List list = Enumerable.ToList((IEnumerable) PrincipalInfo.Current.RoleList);
      
      // This seems to cause the issue. GetDefault method is deprecated and returns the wrong instance
      VirtualRoleRepository @default = VirtualRoleRepository.GetDefault();
      
      // !!! Should use IoC. This retrieves the correct instance
      //VirtualRoleRepository @default = ServiceLocator.Current.GetInstance();
      
      foreach (string name in @default.GetAllRoles())
      {
        VirtualRoleProviderBase virtualRoleProvider;
        if (@default.TryGetRole(name, out virtualRoleProvider) && virtualRoleProvider.IsInVirtualRole(PrincipalInfo.CurrentPrincipal, (object) null))
          list.Add(name);
      }
      if (Roles.Enabled)
        list.AddRange((IEnumerable) Roles.GetRolesForUser(PrincipalInfo.Current.Name));
      return Enumerable.Distinct((IEnumerable) list);
    }

The latest CMS patch is not rollbackable due to DB changes, and I would really like to avoid making own workaround extensions for Find. So, could you release a fix as soon as possible, please :)