Bad exception handling in OrderGroupWorkflowManager.RunWorkflow

Fixed in

EPiServer.Commerce 13.4.0

Created

May 27, 2019

Updated

Jul 05, 2019

Area

Core

State

Closed, Fixed and tested


Description

OrderGroupWorkflowManager.RunWorkflow takes a parameter to indicate if it should throw exception or not. However, this is less than optimal:

  • It should log the exception as an error, or at a least warning, not debug.
  • It should log the exception regardless of the flag.

This makes debugging problems in Commerce Manager very cumbersome because it actively hides exceptions that happen in the workflows.