Can&#39;t mock page types any more

Can't mock page types any more

Tim Brown

Vote:

Hi all

Previous to the upgrade I could mock up base page types (i.e. those inheriting from PageData) e.g.(with Rhino Mocks)

var product = MockRepository.GenerateMock<ProductPageBase>();
product.Stub(p => p.ContentLink).Return(new ContentReference(6));
product.Stub(p => p.Language).Return(new CultureInfo("en"));
return product;

But since the upgrade the GenerateMock line crashes with the following error

Method 'set_LanguageBranch' on type 'Castle.Proxies.ProductPageBaseProxyae202e0229524fd7849a560a662d64dc' from assembly 'DynamicProxyGenAssembly2, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' is overriding a method that is not visible from that assembly.

I have disassembled EPiServer.dll 7.5 and the LanguageBranch set is internal however this is the same as 7.0 dll so that not so illuminating

Does anyone know why this has started to fail and what could be done to get these tests back working. It has broken quite a few tests

Many Thanks for any all help

#79847

Jan 08, 2014 12:56

Lars Loennechen Skjelbek

Vote:

Bump. We have the very same issue. Anyone?

#79980

Jan 13, 2014 10:35

Tim Brown

Vote:

I've had to change the page object to concrete instantiations to get the tests back working

 var searchPage = new SearchPageBase();
            searchPage.Property.Add(new PropertyPageReference { Name = MetaDataProperties.PageLink, Value = new PageReference(6) });

Feels like a step backwards

#80027

Jan 13, 2014 19:15

Erik Täck

Vote:

EPiServer.dll v7.5.409.0 has the assembly attribute set:

[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("DynamicProxyGenAssembly2, PublicKey=0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7")]

While 7.0.586.24 do not, and in that version it works, seems it should be the other way around really, but there is a difference for you atleast.

Edit: Or the fact that dynamicproxy now sees the internal set method and tries to mock it is the reason for it failing.

#80033

Edited, Jan 14, 2014 8:21

Erik Täck

Vote:

Found a semi-workaround for this if you use Castle.DynamicProxy to generate your page proxies, not that its much different from just creating concrete instances using new PageData(), though I personally use a interceptor to populate the Property collection with the data for whatever property I am setting to create sort of a semi-mock whenever the "set_XXX" method is called on the proxy.

This will probably fail spectacularily if you try to do something with the properties "LanguageBranch" & "PageFolderID", but they might help someone get their unit tests running until EPi releases a fix for this.

public class SomeTestUtil
{
	public static T CreatePageDataProxy<T>() where T : PageData
	{
		var opt = ProxyGenerationOptions.Default;
		opt.Hook = new PageDataHook();
			
		return new ProxyGenerator().CreateClassProxy<T>(opt);
	}
}

public class PageDataHook : AllMethodsHook
{
	public override bool ShouldInterceptMethod(Type type, MethodInfo methodInfo)
	{
		if (typeof (PageData).IsAssignableFrom(type)) {
			if (methodInfo.Name == "set_LanguageBranch" || methodInfo.Name == "set_PageFolderID") {
				return false;
			}
		}
		return base.ShouldInterceptMethod(type, methodInfo);
	}
}

Edit, it will make the following test pass:

[Test]
public void Title_should_be_the_same_as_the_page_name()
{
	var page = SomeTestUtil.CreatePageDataProxy<SitePageData>();
	page.Property["PageName"] = new PropertyString("foo");

	Assert.AreEqual("foo", page.Title);
	Assert.AreEqual(page.PageName, page.Title);
}

#80038

Edited, Jan 14, 2014 8:54

Per Bjurström

Vote:

We are looking into this.

Bug 111585 Not possible to mock page types in 7.5

#80520

Jan 24, 2014 8:31

Tim Brown

Vote:

That's brilliant. Thanks for the response

#80892

Feb 04, 2014 14:02

Per Bjurström

Vote:

Fix available in update 5 of the platform (package EPiServer.Cms.Core 7.5.1002)

#81455

Feb 17, 2014 17:01

Tim Brown

Vote:

I'm now on 7.7.0.0 and this is still a problem. Is ithere any further news on this please

Thanks

#87760

Jun 23, 2014 10:18

Tim Brown

Vote:

I've raised a bug with EPiServer. Cheers

#88382

Jul 10, 2014 12:11

Per Bjurström

Vote:

We have only verified the bug using Moq assuming it was the same issue in Rhino Mocks, and it was. But apparently there is also a second issue with Rhino Mocks that have been there for some time, no sure if it have ever worked or if Rhino Mocks made some change recently. We have fixed the bug and it should go out within the next 2 weeks or so..

BUG #116485 Not possible to mock content types using Rhino Mocks

#89248

Aug 12, 2014 10:01