Problem with IShippingPlugin

November Happy Hour will be moved to Thursday December 5th.

AI OnAI Off

Home / Forums / Developers (Main Products) Forum / Customized Commerce 13 and earlier versions /

Problem with IShippingPlugin

Kjetil Simensen

Vote:

Hi,

I've started using ISerializableCart and want to create our own IShippingPlugin. This is my code (at the moment i'm just returning some mock code):

public class Print : IShippingPlugin
    {
        public ShippingRate GetRate(Guid methodId, IShipment shipment, ref string message)
        {
            if (shipment.LineItems.Any())
                return new ShippingRate(methodId, "Print", new Money(110, new Currency("NOK")));

            return new ShippingRate(methodId, "Print", new Money(0, new Currency("NOK")));
        }
    }

However i keep getting this error when i try to run the ICart GetTotal():

Constructor on type 'xx.Print' not found.

Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.MissingMethodException: Constructor on type 'xx.Print' not found.

---

I've tried to add an empty constructor to my code but i still get the error.

Anyone know what's wrong here?

Using:

"EPiServer.Commerce.Core" version="10.3.0"

"EPiServer.CMS.Core" version="10.4.2"

#175744

Mar 01, 2017 9:29

Quan Mai

Vote:

Hi,

You'll have to have a constructor which takes an IMarket as parameter.

public Print(IMarket market)
{
}

I'll check to see if the documentation needs to be updated to reflect that.

Regards,

#175746

Mar 01, 2017 9:43

Kjetil Simensen

Vote:

That worked. Thanks!

#175750

Mar 01, 2017 10:07

Arve Systad

Vote:

Very strange thing to demand from an implementation. Whatever instantiates these should support empty constructors too; It's an implementation detail whether or not a shipping plugin requires the market it belongs to or is used in.

An interface defines the functionality the calling application wants, it should not care exactly how this happens - that's where IOC containers come into play. StructureMap can figure out what the implementation needs based on the constructors it has. Episerver itself should not put any restrictions onto this. What if one wants more input via constructor injections, but none of them are of IMarket implementations?

#175751

Edited, Mar 01, 2017 10:16

Quan Mai

Vote:

That's good point Arve. I have some ideas to improve APIs, but that needs to be discussed within our team first.

#175752

Mar 01, 2017 10:22

Arve Systad

Vote:

Nice.

As with most other things, using Activator.CreateInstance should be avoided when one has an IOC container like StructureMap. If one always calls that and makes sure it gets objects, consuming parties can require whatever they want. It should very often make for a far simpler implementation in calling classes, and a less confusing way of implementing the interfaces. :-)

#175753

Mar 01, 2017 10:26

This topic was created over six months ago and has been resolved. If you have a similar question, please create a new topic and refer to this one.