Hi!

I may have misunderstood exactly what you’re trying to achieve, but from what you describe the recursion is happening because any call to ContentRepository.Save (even with SaveAction.Patch) will always fire the saving/saved events. If that call happens during PublishedContent, you can easily end up in a loop.

One way I’ve handled a similar case is to hook into the PublishingContent event instead. That lets you modify the content right before it’s persisted, without needing to call Save() yourself. For example:

[ModuleDependency(typeof(EPiServer.Web.InitializationModule))]
public class OptimizelyInfiniteLoopFix : IInitializableModule
{
    private IContentEvents? _contentEvents;

    public void Initialize(InitializationEngine context)
    {
        _contentEvents = ServiceLocator.Current.GetInstance<IContentEvents>();

        // Use PublishingContent instead of PublishedContent to avoid infinite loops
        _contentEvents.PublishingContent += OnPublishingContent;
    }

    private void OnPublishingContent(object? sender, ContentEventArgs e)
    {
        if (e.Content is SitePageData sitePageData && string.IsNullOrEmpty(sitePageData.CustomId))
        {
            // Modify content directly - no Save() call needed
            sitePageData.CustomId = e.Content.ContentLink.ID.ToString();
        }
    }

    public void Uninitialize(InitializationEngine context)
    {
        if (_contentEvents != null)
        {
            _contentEvents.PublishingContent -= OnPublishingContent;
        }
    }
}

Hi kristoffer, Thanks for the answer, it is helpful. One thing I am noticing is when I am calling ContentRepository.Save (with SaveAction.Patch) in the Instance_PublishingPage event, it is not firing the saving/saved events. Is there a difference in how this works based on whether we are in the publishing pipeline or not?

Hi Priyanka,

At the publishing event, use this 

private void ContentEvents_PublishingContent(object sender, ContentEventArgs e)
{
    if (e.Content is SitePageData sitePageData)
    {
       SitePageData clone = (SitePageData)sitePageData.CreateWritableClone();
          clone.CustomId = e.Content.ContentLink.ID.ToString();
          contentRepo.Save(clone, SaveAction.Save,AccessLevel.NoAccess);
       
    }

}

Hi,

As I mentioned in my previous post, there’s no need to create a writable clone and call ContentRepository.Save() when working with PublishingContent. You can simply assign the CustomId property, and the pipeline will take care of saving the changes for you.