Hi,

At the moment, no. Commerce uses the same value in UIMaxVersions as CMS does - the request in the link you provided was fixed and released in Commerce 7.10.3. For the simplicity we use the same UIMaxVersions  - as it should apply for all "versionable" content.

Regards.

/Q

ok thanks, so would you happen to have a scheduled job or something similar that trims the version history for product content? Unfortunately upgrading at this point in time isn't an option for our client.

We don't have that by default, but I think you can easily write one to iterate over catalog contents and make the trim.

Regards.

/Q

Hi Quan,

I've hit an issue with my scheduled job.  I keep getting the following error when calling "_contentVersionRepository.Delete(versionContent.ContentLink)" - Access was denied to content 4442_3_CatalogContent. The required access level was "Delete".

If I run this same code by hitting an action on a controller, it works fine (as long as I'm logged in as admin), but running manually (logged in as admin) from the scheduled job keeps failing.

As you can see I've added a few checks to ensure I'm logged in as admin and within the "Administrators" role.

var accessLevel = content.QueryAccess(); // returns read

var contentACL = new ContentAccessControlList(content.ContentLink); // return 0 results

bool userHasDeleteAccess = content.QueryDistinctAccess(AccessLevel.Delete); // returns false

if I try to add the "Delete" access level to the admin user, the save method fails

Is there something I'm missing? anything obvious you can see?

Thanks, Mark

public override string Execute()
{
    if (PrincipalInfo.CurrentPrincipal.Identity.Name == string.Empty)
    {
        PrincipalInfo.CurrentPrincipal = PrincipalInfo.CreatePrincipal("admin");
    }

    var isInAdmin = PrincipalInfo.CurrentPrincipal.IsInRole("Administrators");

    ...
}


private void CheckProductVersions(IContent content, FashionProductContent fashionProduct)
{
    var productContentVersions = _contentVersionRepository.List(content.ContentLink);
    var versionCount = productContentVersions.Count(v => v.LanguageBranch.ToLowerInvariant().Equals(GlobalConstants.DEFAULT_LOCALE));

    // Get the access level for the current user
    var accessLevel = content.QueryAccess();

    // Get the content ACL
    var contentACL = new ContentAccessControlList(content.ContentLink);

    bool userHasDeleteAccess = content.QueryDistinctAccess(AccessLevel.Delete);

    //if (!userHasDeleteAccess)
    //{
    //    contentACL.Add(new AccessControlEntry("admin", AccessLevel.Delete));
    //    contentACL.Save();
    //}

    if (versionCount > _versionLimit)
    {
        _productCount++;

        var count = 0;
        var deleteCount = 0;
        foreach (var versionContent in productContentVersions.OrderByDescending(v => v.Status.Equals(VersionStatus.Published)).ThenByDescending(v => v.Saved))
        {
            if (versionContent.Status.Equals(VersionStatus.Published))
            {
                count++;
            }
            else
            {
                if (count >= _versionLimit)
                {
                    _contentVersionRepository.Delete(versionContent.ContentLink);
                }
                else
                {
                    count++;
                }
            }
        }
    }
}

Hi,

Can you check (by logging/debugging) to see the current user running scheduled job. By default it'll be anonymous. 

You can follw this blog spot to run with a specific account:

http://tedgustaf.com/blog/2008/8/run-a-scheduled-job-as-a-specific-episerver-user/

Regards

/Q

Yeah, already tried that, see first few lines in my code snippet.  I've logged in as admin and when executing the job manually I can see the PrincipalInfo.CurrentPrincipal is the admin user.

Sorry - missed that.

Tried this code on our Sample site, it runs perfectly with admin account:

var contentVersionRepository = ServiceLocator.Current.GetInstance<IContentVersionRepository>();
var referenceConverter = ServiceLocator.Current.GetInstance<ReferenceConverter>();
var contentLink = referenceConverter.GetContentLink(10, CatalogContentType.CatalogEntry, 0);
var productContentVersions = contentVersionRepository.List(contentLink);
foreach(var version in productContentVersions)
{
contentVersionRepository.Delete(version.ContentLink);
}

Note that CatalogContent does not truly implement the ACL, so you might not need those code at all.

Regards.

/Q

And that works for you in a 7.9 install using a scheduled job?

I tested on latest version - 8.13, but I think there would be no difference in this matter between two versions

ok that doesn't really help my situation, can you try against a 7.9 install?  I've tested the following code on the sample mvc site (7.9) and it doesn't work.

I'm guessing there is some context that is used to get the user from and this isn't set, but seems like in the latest version 8.13 this is, so maybe there is a work around I can implement..?

    [ScheduledPlugIn(
        DisplayName = "Remove Old Product Content Versions", 
        Description = "A scheduled job will try to remove old product content versions.", 
        SortIndex = 1)]
    public class RemoveOldProductContentVersionsJob : JobBase
    {
        private const int VERSION_LIMIT = 3;

        public override string Execute()
        {
            var productCode = "TTCN-01";

            var referenceConverter = ServiceLocator.Current.GetInstance<ReferenceConverter>();
            var contentLoader = ServiceLocator.Current.GetInstance<IContentLoader>();
            var versionRepository = ServiceLocator.Current.GetInstance<IContentVersionRepository>();

            var catalogEntryResponse = new CatalogEntryResponseGroup(CatalogEntryResponseGroup.ResponseGroup.CatalogEntryInfo);
            var entry = CatalogContext.Current.GetCatalogEntry(productCode, catalogEntryResponse);

            if (entry != null)
            {
                var entryIdFromCommerce = Convert.ToInt32(entry.CatalogEntryId);
                var entryLink = referenceConverter.GetContentLink(entryIdFromCommerce, CatalogContentType.CatalogEntry, 0);
                var productContent = contentLoader.Get<FashionProductContent>(entryLink);
                var productContentVersions = versionRepository.List(entryLink);

                int count = 0;
                int deleteCount = 0;
                foreach (var content in productContentVersions.OrderByDescending(v => v.Status.Equals(VersionStatus.Published)).ThenByDescending(v => v.Saved))
                {
                    if (content.Status.Equals(VersionStatus.Published))
                    {
                        count++;
                    }
                    else
                    {
                        if (count > VERSION_LIMIT)
                        {
                            // delete
                            versionRepository.Delete(content.ContentLink);
                            deleteCount++;
                        }
                        else
                        {
                            count++;
                        }
                    }
                }

                return string.Format("ProductCode: [{0}], Name: [{1}], Versions: [{2}], Delete Versions: [{3}]", productCode, productContent.Name, productContentVersions.Count(), deleteCount);
            }

            return string.Format("Can't find ProductCode: [{0}]", productCode);
        }
    }

Hi m.hitchcock

I'm having the exact same issue (EPi > V10 ).

Did you manage to solve this? I suspect the problem might be with IContentVersionRepository... do you know if there's any other way to delete a page version, in code?

Raf