Hi,

In workflow source, we could get ParentCatalogEntryId in ValidateLineItemsActivity. So I think you could try adding ValidateLineItemsActivity after CalculateDiscountsVNextActivity.

And you're using workflow or no-workflow process?

/Son Do

Hi Ken,

A workaround for the problem, if you are in hurry or can't locate the source of the problem is to inject your own GiftItemFactory as such:

public class CustomGiftItemFactory : GiftItemFactory
    {
        private readonly IContentLoader _contentLoader;

        public CustomGiftItemFactory(IContentLoader contentLoader, IPriceService priceService) : base(contentLoader, priceService)
        {
            _contentLoader = contentLoader;
        }

        protected override ILineItem CreateGiftLineItem(EntryContentBase entryContent, PromotionProcessorContext processorContext)
        {
            var lineItem = base.CreateGiftLineItem(entryContent, processorContext);
            var parentCode = _contentLoader.Get<EntryContentBase>(entryContent.ParentLink).Code;
            ((LineItem) lineItem).ParentCatalogEntryId = parentCode;
            return lineItem;
        }
    }

Regards,
Joel Yourstone

Thank you both!

I am trying both solutions.

@ Joel - I couldn't quite get it to work that way... but I DID get it to work using code like this:

        protected override ILineItem CreateGiftLineItem(EntryContentBase entryContent, PromotionProcessorContext processorContext)
        {
            var lineItem = base.CreateGiftLineItem(entryContent, processorContext);
            
            // Set the ParentCatalogEntryId, because Epi hasn't done it for some reason:
            if (lineItem != null)
            {
                var variantEntry = _contentLoader.Get<EntryContentBase>(entryContent.ParentEntries.ContentLink);
                var relation = CatalogContext.Current.GetCatalogRelationDto(variantEntry.ContentLink.ID);
                var parentEntryId = relation?.CatalogEntryRelation?.FirstOrDefault()?.ParentEntryId;
                var parentEntry = CatalogContext.Current.GetCatalogEntry(parentEntryId.ToInt(), new CatalogEntryResponseGroup(CatalogEntryResponseGroup.ResponseGroup.CatalogEntryInfo));
                ((LineItem)lineItem).ParentCatalogEntryId = parentEntry?.ID;
            }
            
            return lineItem;
        }

That gives me the ParentCatalogEntryId I need.  Do you see any problems with that approach? (or, do you see an easier way?)

Thanks so much!

It should be possible to solve without resorting to CatalogContext operations:

var parentRef = entrycontent.GetParentProducts().FirstOrDefault();
var parent =_contentLoader.Get<EntryContentBase>(parentRef);
((LineItem)lineItem).ParentCatalogEntryId = parent.Code;

Add the necessary null checks of course :)

Optionally the GetParentProducts extension method might need a repository as parameter, if it does just load it from structuremap in the constructor.

Thank you, that worked well.  The code is simpler.

Just wondering, is CatalogContext considered to be slower/ less efficient?  Or is it just a more complicated solution?

No above all it is more to be considered a legacy solution, epi still use it internally but it is being phased out.

I think most if not all of the functions are already available from other classes/interfaces that can be retrieved with dependency injection.

IContentLoader, ILinksRepository, IRelationRepository and so on.

As a rule of thumb anything that isn't retrieved through dependency injection are due to become obsolete and isn't really future proof.

Ah good to know, thanks!

In case anyone wants to see it, here is my final code for CustomGiftItemFactory:

    public class CustomGiftItemFactory : GiftItemFactory
    {
        private readonly IContentLoader _contentLoader;

        public CustomGiftItemFactory(IContentLoader contentLoader, IPriceService priceService)
            : base(contentLoader, priceService)
        {
            _contentLoader = contentLoader;
        }

        protected override ILineItem CreateGiftLineItem(EntryContentBase entryContent, PromotionProcessorContext processorContext)
        {
            var lineItem = base.CreateGiftLineItem(entryContent, processorContext);
            
            // Set the ParentCatalogEntryId, because Epi hasn't done it for some reason:
            if (lineItem != null)
            {
                var parentRef = entryContent.GetParentProducts().FirstOrDefault();
                if (parentRef != null)
                {
                    var parent = _contentLoader.Get<EntryContentBase>(parentRef);
                    ((LineItem)lineItem).ParentCatalogEntryId = parent?.Code;
                }
            }
            
            return lineItem;
        }
    }

And note that I also took Son Do's advice - I updated our ActivityFlows to use ValidateLineItemsActivity after CalculateDiscountsVNextActivity.

This combination seems to give me what I need.

Great to hear that (y)