Do you think this https://world.episerver.com/forum/developer-forum/Episerver-Commerce/Thread-Container/2018/6/lineitems-removed-from-purchaseorder-on-save/ might have something to do with it ?

Hello Quan!

I looked at this thread as well, but I'm not sure this is the same issue.

I'm running Commerce in a verion that is higher then when the fix mentioned was implemented.

Also, I get a consistent behaviour for products that are part of our filter.

I think the issume might be in some workflow related to missmatch in OrderTotal and the sum of the LineItems, but I'm not sure on how to cntinue to pinpoint the problem.

This is currently my LineItemValidator that try to catch when it item is removed, but it doesn't trigger. Is there another validator I should try and setup logging for to spot the problem? 

 [ServiceConfiguration(ServiceType = typeof(ILineItemValidator), Lifecycle = ServiceInstanceScope.Singleton)]
    public class CustomLineItemValidator : ILineItemValidator
    {
        protected readonly ILogger _log = IfLogManager.GetLogger(System.Reflection.MethodBase.GetCurrentMethod().DeclaringType);
        private readonly ILineItemValidator lineItemValidator;

        public CustomLineItemValidator(IContentLoader contentLoader, ReferenceConverter referenceConverter, ICatalogSystem catalogSystem, IPublishedStateAssessor publishedStateAssessor)
        {
            this.lineItemValidator = new DefaultLineItemValidator(contentLoader, referenceConverter, catalogSystem, publishedStateAssessor);
        }

        public bool Validate(ILineItem lineItem, IMarket market, Action<ILineItem, ValidationIssue> onValidationError)
        {
            return Validate(lineItem, market.MarketId, onValidationError);
        }

        public bool Validate(ILineItem lineItem, MarketId marketId, Action<ILineItem, ValidationIssue> onValidationError)
        {
            return lineItemValidator.Validate(lineItem, marketId, (line, validationIssue) => {
                onValidationError(line, validationIssue);
                LogValidationError(line, validationIssue);
            });
        }

        private void LogValidationError(ILineItem lineItem, ValidationIssue validationIssue)
        {
            _log.Error($"LineItem {lineItem.Code} is not valid: {validationIssue.ToString()}");
        }
    }

You mention OrderStatusManager.CompleteOrderShipment is the trigger. How can I setup a check at this event as well? 

Hello again

I have found a workaround for our issue, but I'm still unclear to why this works.

I split up the function to 3 seprate parts, and now make seprate API-calls for each.

This sloves this issue, and I can have the same product filter as before. 

However, I don't see why this should solve the issue, since it is the exact same code that is executed, only with a little more time between calls. 

This gives the impression that some actions in the order managment doesn't have time to complete before the next call is made? 

It is thill the same user who makes the new API-calls with the same access rights. 

Is it possible that workflows that are triggered from order operations will not have fully completed before next line of code is evalutaed? 

Is there a way to fully wait for workflows to complete?

What I was trying to say is IOrderRepository.Save can't and won't remove items from order, the code that remove them is something else. You should scope it down to find out which code does that, and why. Most common reason is out of stock, but there might be other reasons.