Dynamic Data Store and new properties on Types

A critical vulnerability was discovered in React Server Components (Next.js). Our systems remain protected but we advise to update packages to newest version. Learn More.

When you use access the data store you get your object with the properties from the first time you created the store. If you have added properties on thje type the definition in the store is not updated, and your object will be missing values from the new properties.

That's a bit hassle, since I guess most of you will add new properties after the first time the store is created.

So instead of accessing the store like this

Code Snippet
 public static DynamicDataStore Store
{
    get
    {
        return DynamicDataStoreFactory.Instance.GetStore(typeof(ProductItem)) ??
               DynamicDataStoreFactory.Instance.CreateStore(typeof(ProductItem));
    }
}
 

Code Snippet
 public static DynamicDataStore Store
{
    get
    {
        return DynamicDataStoreFactory.Instance.GetCreateEnsureStore(typeof(ProductItem));
    }
}
 

Where the actually code is like this.

Code Snippet
 using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
 
namespace EPiServer.Data.Dynamic
{
    public static class StoreExtensions
    {
        static object lockObject = new object();
        static Dictionary<Type, bool> done = new Dictionary<Type, bool>();
        public static DynamicDataStore GetCreateEnsureStore(this DynamicDataStoreFactory factory,Type type)
        {
            bool isFirstTime = true;
            lock (lockObject) 
                if (!done.TryGetValue(type, out isFirstTime))
                    isFirstTime = true;
            if (isFirstTime)
            {
                var result= factory.GetStore(type);
                if (result == null)
                    result = factory.CreateStore(type);
                else
                {
                    var def = result.StoreDefinition;
                    def.Remap(type);
                    def.CommitChanges();
                }
                lock (lockObject)
                {
                    done[type] = false;
                }
                
            }
            return factory.GetStore(type);
        }
 
    }
}
 

This code will on the first time it get accessed, checks if the store exits, and if not creates it. And if it exists, it will be remap to the type before it returns the store.

Jan 12, 2011

Comments

Erik Nordin Wahlberg Jan 12, 2011 09:25 PM

Nice one, was wondering how to solve this the other day. :)

Anders Hattestad Jan 12, 2011 10:51 PM

My previous method was to delete the store and create a new one...
So it’s a big improvement :)

Jan 13, 2011 09:19 AM

Interesting code, but I can't figure out why you use the lockObject? Is it only to make it thread safe or what is its purpose?

Anders Hattestad Jan 13, 2011 10:20 AM

Just to make it thread safe,
I thought that could be a good idea, but I quess most of the times this isn't a problem.
I lock when I do a read, but are not sure if that's necessery. Did google it, and was some contradiction statements about it

smithsson68@gmail.com Jan 13, 2011 03:29 PM

You can also check if the store actually needs remapping like this:

var def = result.StoreDefinition;
if (!def.ValidateAgainstMappings(typeof(type), false))
{
def.ReMap(typeof(type));
def.CommitChanges();
}

Anders Hattestad Jan 13, 2011 05:39 PM

That was a good tip. It felt wrong to always remap the store, but I didn't bother to look further.

Anders Hattestad Jan 13, 2011 06:00 PM

Have added Mr Smith's code and uploaded it here
http://world.episerver.com/Code/Anders-Hattestad1/GetCreateEnsureStore/

Joshua Folkerts Jan 31, 2011 02:43 PM

Very nice. I was trying to do this, this weekend. Thanks for the generosity.

Please login to comment.