Five New Optimizely Certifications are Here! Validate your expertise and advance your career with our latest certification exams. Click here to find out more
AI OnAI Off
EPiServer.Logging beta messageFormatter arguments
I would go with overload. Sometimes it's necessary to know what kind of exception was thrown or at what level it was.
Jan 16, 2015 0:53
You still have the type of the exception inside the scope of the messageFormat its just wrapped earlier then the Log method
But if they go for overloads they should also make some that dont require the TState object as that can be a bit confusing.
Jan 16, 2015 11:36
How can I access type of the exception if formatter would be another method? Like:
public string FormatErrorMessage() { .. }
Log(Error, null, exc, FormatErrorMessage);
Jan 16, 2015 11:48
I would do it like:
public string FormatErrorMessage(FormatException ex) { .. }
Log(Error, null, exc, () => FormatErrorMessage(exc));
Edited,
Jan 16, 2015 11:49
Hi
I have a suggestion to the new EPiServer.Logging beta
The new ILogger.Log method has the following signature:
void Log(Level level, TState state, TException exception, Func messageFormatter) where TException : Exception; Wouldn't it be better to have a simple signature like the following:
void Log(Level level, TState state, TException exception, Func messageFormatter) where TException : Exception; This would make it simpler to use and TState and TException is still accessible where the Log method is called:
_logger.Log(Level.Error, (object) null, exception, () => { return string.Format("Sample Format Message {1}", exception.Message) });