can you post the code for GetRecordsForContent also?

and for this.DynamicDataStore as well :)

In other words - please provide full fragment of source code for problematic area in order to find out an issue.

Hello,

Code for GetRecordsForContent and this.DynamicDataStore below. Any thoughts or suggestions appreciated.

        public DynamicDataStore DynamicDataStore
        {
            get
            {
                DynamicDataStore dynamicDataStore = DynamicDataStoreFactory.Instance.GetStore(_dynamicDataStoreName);
                if (dynamicDataStore == null)
                {
                    dynamicDataStore = DynamicDataStoreFactory.Instance.CreateStore(_dynamicDataStoreName, typeof(TDataStoreItem));
                }
                return dynamicDataStore;
            }
        }


        public IEnumerable<TDataStoreItem> GetRecordsForContent(string itemId)
        {
            DynamicDataStore store = this.DynamicDataStore;

            if (store != null)
            {
                return
                    from TDataStoreItem record in store.Find(ContentItemKey, itemId)
                    select record;
            }
            
            return null;
        }

       //ContentItemKey is a string set to "ItemId"

If it's possible try to keep dynamic store into a class member (for that you most probably will need to move type argument to class level):

using EPiServer.Data.Dynamic;

public class  ... <TDataStoreItem>
...
    private DynamicDataStore store;

    private DynamicDataStore Store
    {
        get
        {
            if (this.store == null)
            {
                this.store = typeof(TDataStoreItem).GetStore();
            }

            return this.store;
        }
    }

what about just do 

foreach (var item in (from item in this.DynamicDataStore where item.ItemId==itemId select item))

{

item.Delete();

}

Your code is probably failing for 2 reasons:

1. You don't implement an ID property like this on the object you are trying to store

public Identity Id { get; set; }

2. You are not using the same DynamicDataStoreInstance when you retrieve objects and when you try to delete them. These lines will get the first instance of DDS
----------------------
public void DeleteRecordsForContent(string itemId)
        {
            DynamicDataStore store = this.DynamicDataStore;
...but this line:
foreach (TDataStoreItem storeItem in this.GetRecordsForContent(itemId))
will call...
-----------------
 public IEnumerable<TDataStoreItem> GetRecordsForContent(string itemId)
        {
            DynamicDataStore store = this.DynamicDataStore;
...but DynamicDataStore property doesn't save the instance so you will get a new one...
--------------
public DynamicDataStore DynamicDataStore
        {
            get
            {
                DynamicDataStore dynamicDataStore = DynamicDataStoreFactory.Instance.GetStore(_dynamicDataStoreName);

Fix either of these and it should work...

Thanks all for your responses, Daniel's helped me resolve the issue. I ended up passing the DynamicDataStore object into the method GetRecordsForContent to ensure I was using the correct instance. It's not that clean but it works!

Thanks again,

Mark